DanielLeens commented on PR #11863:
URL: https://github.com/apache/seatunnel/pull/11863#issuecomment-5379449716
Quick status update, no new commit on this PR since my last review.
Two things changed since I approved this at head 471e4efb1:
1. **CI completed and is now red, but for a reason unrelated to this PR's
code.** I pulled the raw log for the fork's `unit-test (8, windows-latest)` job
(run 32343902704) - the failure is a Maven build-level error, not a test
failure:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.12.1:attach-descriptor ...
Could not transfer artifact
org.apache.maven:maven-repository-metadata:jar:3.2.5 from/to central ...
Connection reset
```
That's a transient Maven Central connectivity blip while resolving an
unrelated plugin dependency, well before any Pulsar test would even run.
Nothing to fix in your diff for this - it would need a rerun, not a code change.
2. **More importantly: #11792 - the sibling PR I flagged in my approval as
the most complete of the three duplicate implementations - merged into `dev` on
2026-08-20, a few hours after my approval here.** That's also why this PR now
shows a merge conflict against `dev` (both PRs touch the same lines in
`PulsarMultiTableConfig.java`/`PulsarSource.java`). Since #11792 already ships
the same fix for issue #11620 (single-table `format = text` support, docs, and
the deserialization-correctness test), this PR is now superseded rather than
something to resolve conflicts on and merge separately.
My recommendation: rather than rebasing to resolve the conflict or waiting
on a CI rerun, it'd be best to close this PR in favor of the already-merged
#11792, since keeping it open would just mean re-doing work that's already on
`dev`. Thanks again for tracking this down originally - the diagnosis here was
correct, it just ended up landing through the other PR first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
