DanielLeens commented on PR #11874: URL: https://github.com/apache/seatunnel/pull/11874#issuecomment-5379462367
Quick CI follow-up on my earlier approval, @zhang-arvin. The `Build` check on the current head (`c715b4e0e2`) is still failing, so I went and checked what's actually failing since I only said "once CI is green" generically last time without digging in: - `Run / unit-test (8, windows-latest)` fails in `seatunnel-engine-server`'s `CoordinatorServicePipelineCleanupTest` (`AbstractSeaTunnelServerTest.before` throws `IllegalStateException`, ~311s elapsed) — this matches a known Windows Hazelcast "Node failed to start!" flake pattern that's been seen on unrelated PRs before, not something specific to this diff. - `Run / updated-modules-integration-test-part-2 (8, ubuntu-latest)` fails during dependency resolution for `connector-jdbc-e2e-part-1`: `Could not transfer artifact org.testcontainers:mariadb:jar:1.17.6 ... Connection reset` — a Maven Central network timeout before any test even ran, not a test failure. This PR's diff only touches `YashanDbTypeConverter.java`/its test (a two-`case`-label switch extension), which is nowhere near `seatunnel-engine-server` or the mariadb testcontainers dependency. Both failures look like ordinary CI infrastructure flake, unrelated to this change. This branch is currently 24 commits behind `dev`. Recommended next step: rerun the two failed jobs; if you have push access on your fork to trigger that, that's the fastest path, otherwise a maintainer can rerun. Given how far behind this branch is, syncing onto latest `dev` before the next CI run is also a reasonable idea, though I don't have a specific landed fix to point to for either flake. My approval stands either way — no code-side blockers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
