DanielLeens commented on PR #9898: URL: https://github.com/apache/seatunnel/pull/9898#issuecomment-5379744923
Following up on the one open item from my last review (the CI result), since I said I'd approve once it came back green. Status check on the same head (`269f37e06e0c`, no new commits since): - The `Build` run I flagged as still `in_progress` (fork run `32093735779`, and the equivalent Apache-side check `95581717681`) has since completed — but as `cancelled`, not `success` (completed at `2026-08-18T05:12:48Z`, about 1h36m after my review). So the CI result never actually resolved green; it was cancelled instead. I'm not treating a cancelled run as equivalent to a passing one, so the approval I offered is still pending on a real green run. - Separately, the branch has since drifted from `dev`: `git compare dev...269f37e06e0c` now reports `diverged` (8 ahead / 33 behind), and GitHub shows `mergeStateStatus: DIRTY` / `mergeable: CONFLICTING`. I hadn't flagged this before since it wasn't the case at review time — worth syncing with `dev` while re-triggering the build anyway. Code-side, nothing has changed since my last review and I have no new concerns there. Once the Build check comes back with an actual green result on a synced head, I'm still happy to approve. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
