SEZ9 commented on PR #11489: URL: https://github.com/apache/seatunnel/pull/11489#issuecomment-5381238607
Thanks @DanielLeens for the thorough from-scratch re-review on `2b840e97663480e10bef169ac963a0ae6580dccb` — great to see both of your previous blockers confirmed resolved, with the `TaskExecutionService.java` change removed entirely and the test TOCTOU risk closed via the added `awaitCheckpointCoordinatorsReady(jobMaster)` calls in `SavePointBusySourceTest.java`. Your confirmation that the rest of the diff is byte-for-byte unchanged since your last round is much appreciated. Thanks also @dybyte for the +1. Remaining asks before merge: 1. Per @DanielLeens's process note, the overall `reviewDecision` is still `CHANGES_REQUESTED` due to stale reviews from earlier rounds. I'll ask those reviewers to re-affirm against the current head, or a maintainer with write access can dismiss the stale reviews so this clears the merge gate. 2. Per @dybyte's condition, we need CI to pass on the current head before merging. Once those two are done, this should be good to go. Thanks all for the careful work on the stop-with-savepoint hang fix. <!-- streview-comment:451 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
