SEZ9 commented on issue #10753: URL: https://github.com/apache/seatunnel/issues/10753#issuecomment-5385643026
Thanks @goutamadwant for preparing the Google Pub/Sub sink as the first slice for #10753 — sink-only with #11877 is exactly the kind of small vertical slice we asked for on this tracker. The scope you describe sounds well contained: - JSON / delimited text payloads for V1 is a reasonable initial format boundary - ADC, service account key file, and emulator support covers the main auth paths - flushing outstanding publishes on checkpoint/shutdown and surfacing publish failures to the task are the right delivery semantics to nail down first - unit coverage plus emulator E2E across Flink, Zeta, and Spark is the level of coverage we want before merge Keeping the source side separate is also the right call — subscriber acknowledgements and checkpoint recovery deserve their own design discussion, so please track that as a follow-up slice rather than expanding #11877. Concrete remaining asks before review: 1. Confirm #11877 targets the `dev` branch. 2. Make sure the PR includes the option docs and at least one example config for each supported auth flow (ADC, key file, emulator). 3. In the PR description, spell out the failure semantics explicitly (what happens on publish failure — retry behavior vs. task failure) so reviewers can verify it against the checkpoint flush behavior. 4. Link #11877 back to this umbrella issue so tracking stays in one place. Detailed review will happen on the PR itself. Thanks again for the well-scoped contribution! <!-- streview-comment:481 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
