SEZ9 commented on PR #11564: URL: https://github.com/apache/seatunnel/pull/11564#issuecomment-5385641459
Thanks @DanielLeens for the detailed follow-up and for correcting your earlier read of the `Build` run — much appreciated. Agreed on all points: 1. **Head SHA** — good, `e01712f9` unchanged since 2026-08-19 and byte-for-byte identical to the head you approved on 08-04. That matches my expectation; no further push is needed from a review standpoint. 2. **CI status** — I see the same thing: `Build` on `e01712f9` is `failure` (https://github.com/apache/seatunnel/runs/95934660228). Given the failing jobs (`unit-test (11, windows-latest)`, `engine-v2-it (8, ubuntu-latest)`, `all-connectors-it-7 (11, ubuntu-latest)`, `doris-connector-it (8, ubuntu-latest)`) don't touch `ReportMetricsOperation`/`ReportMetricsOperationTest` and this head passed CI twice before, I agree this looks like environment-level flakiness rather than a regression from this PR. That said, we shouldn't merge on a red check — the rerun of the failed jobs (`gh run rerun <run-id> --failed` on the fork run) is the remaining blocker. Since your access is read-only, that has to come from the PR author; asking them to trigger it and report back here once it's green. 3. **Follow-up tracker** — agreed a short issue for the `shouldKeepRemoteGenericOperationsResponsiveWhileMetricsWaitForOffloadExecutor` timeout-centralization note is the right way to keep it from being lost. To avoid it stalling on "whoever gets to it first," I'll file it after merge and link it back to this thread. So concrete remaining asks: - PR author: rerun the failed `Build` jobs on `e01712f9` and confirm green here. - Nothing further from review side — your APPROVED conclusion stands and the diff is unchanged, so once CI is green this is ready to merge. <!-- streview-comment:489 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
