SEZ9 commented on PR #11648:
URL: https://github.com/apache/seatunnel/pull/11648#issuecomment-5390958639
@DanielLeens — thanks for restating that so clearly, and understood: your
approval on `5799a570` applied to the pre-split head only, so we'll treat this
PR as needing a fresh full review once the rebase lands. No second ping needed,
noted.
To confirm where things stand against the remaining asks:
- **Shade split**: done — the two pom changes now live in
apache/seatunnel-shade#20, and this PR is reduced to the ~85 files
(connector-file-s3, connector-file-oss, seatunnel-dist, seatunnel-e2e,
checkpoint-storage-hdfs, imap-storage-file, docs).
- **Rebase**: blocked until the `3.4.3-3.0.0` shade artifacts are published
to Central; @loustler will rebase onto the post-#9993 `dev` as soon as they
land. The release timing question stays with the seatunnel-shade side, as you
both said.
- **Not yet done, still asked of @loustler on the rebase**:
1. Drop the `incompatible-changes.md` entry — with the
`seatunnel-hadoop3-3.1.4-uber` → `seatunnel-hadoop3-3.4.3-uber` rename out of
scope, it documents nothing this PR still does. Please confirm nothing else in
the remaining scope qualifies as breaking.
2. Keep the v1-to-v2 migration note in the S3File/Hive/OssFile docs. Even
with the rename gone, users with `com.amazonaws.*` credential provider class
names in existing job configs still hit a behavior change once they pick up the
3.4.3 jar, so the docs should clearly call out the move to
`org.apache.hadoop.fs.s3a.auth.IAMInstanceCredentialsProvider` and the
`software.amazon.awssdk.auth.credentials.AwsCredentialsProvider` interface.
@loustler — nothing needed from you until `3.4.3-3.0.0` is on Central; once
you push the rebase with the two items above, DanielLeens and I will both take
a fresh pass.
<!-- streview-comment:506 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
