DanielLeens commented on PR #11577: URL: https://github.com/apache/seatunnel/pull/11577#issuecomment-5391457727
Sounds good -- thanks for tracking down that the `AbstractBigQuerySinkWriter` concern is still open and clarifying it just wasn't repeated this round to keep things focused; agreed it should stay carried forward alongside Issues 1, 4, and 5. Aligned on the priority order too: Issue 1 (unescaped/unvalidated identifiers reaching the `ALTER TABLE ... ADD COLUMN` DDL via `BigQuerySchemaChangeManager`) is the hard blocker regardless of where the other three land, since that is a straightforward injection surface off CDC-supplied column names. Issues 4 and 5 landing together makes sense given they both touch the restore/consistency path. @dybyte -- once you have a commit addressing Issue 1 at minimum (ideally with 4/5 alongside, plus a note on the writer API question), ping us both and we will split the re-review as SEZ9 suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
