Merlin-S3NS commented on PR #11649: URL: https://github.com/apache/seatunnel/pull/11649#issuecomment-5397044272
Dear @DanielLeens, Thank you so much for the deep dive and for double-checking the exact call path in `validateSchemaCoherence()`! Your call-stack analysis is spot on — `catalog.getTable()` uses the classic REST client which only throws `BigQueryException`. In the latest commit (`0631c6cc`): 1. **Simplified Exception Catch**: Refactored `validateSchemaCoherence()` in `BigQuerySaveModeHandler.java` to catch `BigQueryException` directly, removing the dead-code branches. 2. **Rebased on `dev`**: Merged the latest `dev` branch to pick up commit `43fe63b1fca` (which resolves the transient `seatunnel-engine-server` Zeta event timeout build break). 3. **PR Description Updated**: Added the complete Protobuf & Netty shading relocation rationale directly into the PR description body under "Shading & Dependency Relocation Notes". All 138 unit tests pass cleanly locally (`BUILD SUCCESS`). Thank you again for such a thorough, insightful, and enjoyable review process! Ready for merge whenever you have a moment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
