SEZ9 commented on PR #11597: URL: https://github.com/apache/seatunnel/pull/11597#issuecomment-5409351814
Thanks @DanielLeens for the thorough, repeated passes on this — the end-to-end trace of both the v2 Jetty path and the legacy `/hazelcast/rest/maps/running-jobs/slot-usage` path is very helpful, and I appreciate that you re-verified against the current head (`7c43aaf8fa7`) rather than relying on the earlier write-up from the `20538ae1eb` round. A few things I'd like nailed down before we can move forward: 1. **CI outcome for the current head.** You mention the fork CI run for `7c43aaf8fa7` has now completed and that "it changes the bottom line," but the actual result and its impact aren't spelled out in the thread. Please post the concrete outcome and what the new bottom line is — right now we can't tell whether this pass ends in approval or new blockers. 2. **Status of Issues 2 and 3.** Your Aug 23 review confirms Issue 1 (the `slotCount: 0` vs. source-not-ready ambiguity, now addressed via the `assignedSlotSourceInitialized` / `slotSourceAvailable` signal) is fixed at `7c43aaf8`. However, the re-verification results for the other two declared blockers from your 2026-08-22 round aren't visible here. Please state explicitly whether each is fixed, still open, or superseded. On the substance itself: the design — a purely additive, read-only endpoint with worker-to-master forwarding via `GetRunningJobSlotUsageOperation` and the explicit staleness flag instead of a silent `0` — looks sound based on your trace. Once the CI result and the Issue 2/3 statuses are confirmed on the thread, we should have everything needed to conclude this round. <!-- streview-comment:559 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
