SEZ9 commented on PR #11408: URL: https://github.com/apache/seatunnel/pull/11408#issuecomment-5421602619
Thanks @DanielLeens — confirmed and aligned. Head is still `f0b0eb1e1d36` with no new commit, so there is nothing new to re-verify and changes-requested stands. The four asks remain the path to a mergeable state, and none are done yet: 1. Remove the `solution_*.py` files and implement the fix in Java inside `seatunnel-connectors-v2/connector-cdc/connector-cdc-tidb` so it is part of the Maven build and actually executes in a Zeta/Flink/Spark job — this stays the fundamental blocker. 2. Resolve the constructor/default ambiguity so there is exactly one initialization path, with no `None` defaults feeding arithmetic. 3. Fix the dead-code guard where `lastKnownGoodTs` is always assigned equal to `resolvedTs`, and add regression coverage for the resolved-ts reset behavior plus ASF license headers on any new files. 4. Sync with the latest `dev` and rerun the `Build` gate to separate baseline CI noise from code-side issues. Once a real Java-side commit covering these lands, I'll ping you and we can do the full re-review together on the new head. Thanks for the rigorous cross-checking — both of our reads converging on the same root causes made this state easy to confirm. <!-- streview-comment:564 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
