SEZ9 commented on PR #11983:
URL: https://github.com/apache/seatunnel/pull/11983#issuecomment-5448368772
Fixed in f925763a7 — the blocker is legitimate and I should have grepped
wider the first time.
`Log4j2HttpPostCommandProcessor#setLoggerLevel`'s javadoc still read
*"applied as a `null` level, which
log4j2 silently ignores"*, i.e. exactly the misconception this PR exists to
remove, sitting on the
method the PR rewrites. It now says the same thing as `LogLevels.parse` and
`incompatible-changes.md`:
```java
* <p>An unknown level name is rejected with {@code 400} instead of
being applied as a {@code
* null} level, which clears the logger's explicit level rather than
leaving it unchanged.
```
Documentation only, no behaviour change. I also grepped the rest of the tree
for the same claim in the
log-level path and there is no other occurrence, so this was the last one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
