DanielLeens commented on PR #11968: URL: https://github.com/apache/seatunnel/pull/11968#issuecomment-5459177236
Follow-up on CI status for this review round: the `Build` check has now completed on the head I reviewed (`4b73f4c6`), and it is `FAILURE` — the same category of gap as on the sibling GCS-source PR (#11967). The **`Dependency licenses`** job reports: ``` -snmp4j-2.8.18.jar ``` `tools/dependencies/known-dependencies.txt` is missing the `snmp4j-2.8.18.jar` entry, so the automated dependency-license cross-check fails. This narrows what I said in my review under the registration-matrix check (I listed NOTICE/LICENSE and `known-dependencies.txt` as cross-checked and complete, based on a source read while CI was still in progress). Concrete next step: add `snmp4j-2.8.18.jar` to `tools/dependencies/known-dependencies.txt` and push. The other three failing jobs on this head are pre-existing infra flakes, not connected to this PR's SNMP code: - `unit-test (8, windows-latest)`: Maven Central `429 Too Many Requests` resolving `guava-retrying` for an unrelated module (`connector-http-base`). - `unit-test (11, ubuntu-latest)`: a single test error in `seatunnel-engine-server`, unrelated to the SNMP source. - `jdbc-connectors-it-part-6 (11, ubuntu-latest)`: `JdbcHanaIT` Testcontainers launch failure, unrelated to this PR. A rerun should clear those on their own; only the `known-dependencies.txt` gap needs a code change. Once that entry is added and the full build is green, this is good to merge from my side; the rest of my review (Recommended fixes, non-blocking) still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
