DanielLeens commented on PR #11967: URL: https://github.com/apache/seatunnel/pull/11967#issuecomment-5459176784
Follow-up on CI status for this review round: the `Build` check has now completed on the head I reviewed (`0287252d`), and it is `FAILURE` — specifically the **`Dependency licenses`** job. The diff it reports is a real, single-line gap: ``` -gcs-connector-hadoop3-2.2.33-shaded.jar ``` `tools/dependencies/known-dependencies.txt` is missing the `gcs-connector-hadoop3-2.2.33-shaded.jar` entry, so the automated dependency-license cross-check fails. This directly narrows what I said in my review under the registration-matrix check (I listed `known-dependencies.txt` as cross-checked and complete — that was based on a source read, not a CI-verified diff, and the CI run had not finished at review time). Concrete next step: add `gcs-connector-hadoop3-2.2.33-shaded.jar` to `tools/dependencies/known-dependencies.txt` and push; that should be sufficient to turn the `Dependency licenses` job green. The other failing job on this head (`jdbc-connectors-it-part-1 (11, ubuntu-latest)`) failed on a Maven Central `429 Too Many Requests` while resolving the wrapper jar (infra flake, unrelated to this PR's code) — a rerun should clear that one on its own, no action needed there. Once the `known-dependencies.txt` entry is added and the full build is green, this is good to merge from my side; the rest of my review (Recommended fixes, non-blocking) still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
