DanielLeens commented on PR #11940: URL: https://github.com/apache/seatunnel/pull/11940#issuecomment-5473666695
CI status update on the latest head (`e5465cd9`, the `Merge branch 'dev' into feature/GH-10753-stripe-source` commit). I checked the merge commit's own diff first: it touches `config/plugin_config` (only additions from `dev` for unrelated new connectors, no deletions) and a batch of unrelated `docs/en`/`docs/zh` and workflow files pulled in from `dev` — it does not touch any Stripe connector file (`connector-http-stripe/**`, `StripeIT.java`, etc). So there's no new Stripe-related code to re-review here; my prior approval (2026-08-26, on `25cd9c14`) still stands for the connector's own logic, tests, and docs. On CI: the fork's first attempt for this head (`goutamadwant/seatunnel` run 33324804783, attempt 1) failed, but on `seatunnel-engine-server`'s `CoordinatorServiceTest.testClearCoordinatorServiceDropsPendingJobsUnderRejectStrategy` (`ConditionTimeout` at line 642) — a pre-existing engine unit test with no relationship to the `connector-http-stripe` module this PR adds. A second attempt is already running (started ~03:25 UTC, currently on `unit-test (11, ubuntu-latest)`), so no action is needed from @goutamadwant right now — just let this attempt finish. Since my approval already covers the connector code and this failure is unrelated to it, this should be ready to merge once the in-progress rerun completes green. As a comment-only reviewer I can't perform the GitHub-level merge myself, so a maintainer with write access will still need to do that step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
