DanielLeens commented on PR #11996: URL: https://github.com/apache/seatunnel/pull/11996#issuecomment-5473723425
CI is green on the current head (536b39b) - the Build check completed successfully, so that part is confirmed. On the sweep question: I went through both connector modules looking for other emptiness checks matching this PR's pattern (`Collection.size() > 0` / `== 0` used purely as an emptiness test). The five call sites already fixed here cover every `List`/`ArrayList` instance I could find in `connector-easysearch` and `connector-elasticsearch`. There is one more emptiness check outside this diff: `connector-elasticsearch/.../client/EsRestClient.java`, `unwrapFieldValue`, `fieldValue.size() == 0`. It's a different situation though - `fieldValue` is a Jackson `JsonNode` (an array-type node), not a `List`/`Collection`, and the check is the opposite polarity (`== 0`, guarding the "leave as-is" branch rather than `> 0`). The project pins `jackson.version` to 2.15.4, and `JsonNode.isEmpty()` has existed since Jackson 2.10, so it would be a valid drop-in swap there too, but since it's a different type than the five sites already covered, I'd leave it to @corgy-w's judgment whether to fold it into this PR or handle it separately - either is fine from a review standpoint and it doesn't block merging what's already here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
