SEZ9 commented on PR #12003: URL: https://github.com/apache/seatunnel/pull/12003#issuecomment-5476208168
Thanks @DanielLeens for the detailed writeup, and thanks @davidzollo for the pointer to https://github.com/apache/seatunnel/pull/12001. Since that PR landed first and addresses the same issue, deduplicating makes sense. @DanielLeens, before closing this one, could you review https://github.com/apache/seatunnel/pull/12001 and confirm it covers the concerns raised here? 1. That the string-equality contract between the runtime row table id and the mapping key's full name is enforced rather than assumed. 2. Whether a lookup miss still silently falls back to `default.default.default` with no diagnostics — if so, please raise it on that thread. 3. Whether its test coverage includes db-first ids, unmapped table ids, and the default fallback, and verifies the real key-format contract rather than mocking the sink table mapping. 4. That the user-visible metric label change is noted in the release changelog. If it checks out, please close this PR with a link so the history stays traceable. Thanks both! <!-- streview-comment:694 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
