DanielLeens commented on PR #10447: URL: https://github.com/apache/seatunnel/pull/10447#issuecomment-5480365473
Hi @goutamadwant, thanks for checking in on this one — I re-checked the current PR state to answer your status question with the latest facts. Current head is still `f399efa6328f` (unchanged since my last full review on 2026-07-19), so nothing new has landed on the code side. The one remaining blocker from that review is still open and unchanged: `docs/zh/connectors/source/HubSpot.md` still places the ASF header (`<!--`) as its first line instead of the required changelog import / first-level heading, so `MarkdownTest.testPrimaryHeadersHaveNoTextAbove` and `MarkdownTest.testConnectorDocWithChangeLogFlagAndFile` still fail deterministically — that's the sole failure in the current `Build` check run: https://github.com/Suresh-Krishna-Kusuma/seatunnel/actions/runs/29634954624/job/88055559969 Separately, and this is new since my last check: the branch is now quite far behind `dev` (`behind_by=293`, compare status `diverged`) and GitHub is reporting a real merge conflict (`mergeable_state=dirty`). That will need to be resolved before CI can give a clean signal either way. @Suresh-Krishna-Kusuma, so to unblock: please (1) sync this branch with the latest `dev` and resolve the conflicts, and (2) fix the doc header ordering in `docs/zh/connectors/source/HubSpot.md` to match the other connector docs. Once both are done and CI is green, I'm happy to take another pass — the core HubSpot pagination/runtime-wiring work from earlier rounds still looks solid to me, this is just the two items above standing between this and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
