DanielLeens commented on PR #11995: URL: https://github.com/apache/seatunnel/pull/11995#issuecomment-5480612417
CI has now fully concluded on the current head (`67162eeb`) — the Build check completed successfully, so the "pending / not fully concluded" state I noted in my last review is resolved. That doesn't change the merge-readiness bottom line though: Issue 1 (a one-line comment on `close()` explaining why no synchronization/wait is needed after the sleep removal) and Issue 3 (class-level Javadoc on `AssertSinkWriterCloseTest`) are still open asks from my review, and there's no new commit on the branch since then. Once those land I'll do a final pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
