SEPURI-SAI-KRISHNA commented on PR #11927: URL: https://github.com/apache/seatunnel/pull/11927#issuecomment-5505527260
Closing this as superseded rather than merging it. No work is outstanding; it has all landed by another route. This PR's single commit, `3de3d9cd`, was rebased into #11937 as `4a6ca5f3c` under the same title. #11937 merged into `dev` on 2026-09-01 as `2a96f18b`, so everything proposed here is now on `dev`: | This PR added | On `dev` today | |---|---| | `checkIntegralRange` helper | declared at `NumericFunction.java:371`, called at `:349`, `:353`, `:357`, `:360` | | `absOverflow` helper | declared at `:386` | | `ABS` MIN_VALUE guards | `:39` TINYINT, `:46` SMALLINT, `:53` INT, `:60` BIGINT | I confirmed this by diffing `NumericFunction.java` on `dev` against this branch's copy rather than trusting the titles: `dev` is a strict superset. The only lines this branch carries that `dev` does not are its older base, specifically the pre-#11918 `private toBigDecimal` and the pre-locale-fix `toUpperCase()` call, both of which `dev` has since moved past on its own. That is also the entire reason this PR reads `CONFLICTING`. The branch is stale against five weeks of `dev`, not blocked on anything. Rebasing it would resolve the conflict and then produce an empty diff, which is why closing is the honest outcome. #11926, which this PR was set to close, is fixed on `dev` and I am closing it separately with the same evidence. @DanielLeens, thank you for the review here and for the `PostgresCDCIT` triage. Your call that the `all-connectors-it-7` failure was testcontainer timing unrelated to this diff held up: the identical commit went green in #11937 with no code change on its account, and your approval carried straight through to the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
