davidzollo commented on PR #11503: URL: https://github.com/apache/seatunnel/pull/11503#issuecomment-5509580210
I dismissed @SEZ9's 2026-08-22 CHANGES_REQUESTED review as stale. I independently re-verified all three concerns it raised against the current head (a78cbe5ba7): - The blocking "default.default" legacy table-id fallback (Issue 1) was fixed in b99b1a1b91 and refined in 6e4c00f6b5: `IncrementalSourceReader.restoreLegacyCheckpointTables()` now derives the real table path from `incrementalSplit.getTableIds()` / `MultipleRowType.getTableIds()` instead of a hardcoded literal. - The wholesale `clear()+putAll()` on the shared Debezium history map (Issue 4) was fixed in b99b1a1b91: `AbstractDebeziumDeserializationSchema.getHistoryTableChanges()`, `restoreCheckpointHistoryTableChanges()`, and the live `deserialize()` mutation now all synchronize on `tableChangesStructMap`, removing the race with `addSplitsBack()`-delivered live records. - The missing Javadoc on the new public API surface (Issue 7) was added in b99b1a1b91 for `DebeziumDeserializationSchema#restoreCheckpointHistoryTableChanges`, and `RestoreTableSchemaEvent` got a class-level Javadoc documenting the `SCHEMA_CHANGE_RESTORE` consumer contract in b99b1a1b91 and 1e5493c9f8. No action needed from the contributor on these three points. This is otherwise blocked only on CI and further human review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
