BinTaoMa commented on PR #11924: URL: https://github.com/apache/seatunnel/pull/11924#issuecomment-5518953625
> 已审阅最新款头部`7c1e180`。 > > ### 合并结论：请求更改 > **阻塞：与 PR [#11999 的协调](https://github.com/apache/seatunnel/pull/11999)** > > [此 PR 和#11999](https://github.com/apache/seatunnel/pull/11999)都通过修改修复了同一个问题 ( #11755`TaskExecutionService.java` ) 。 我们需要弄清楚如何处理这两个 PR 的实现——请查看#11999的详细信息。 > > **其他需要修复的问题：** > > 1. `closeTimerFlushTaskForGeneration`括号内有死代码`TaskExecutionService.java`：空返回保护后的检查无法执行。 > 请 > 简化为。`future != null``if (!future.isDone())` > 2. `taskAsyncFunctionFutureByGeneration`并`timerFlushFuturesByGeneration`依赖于 > `cancelAsyncFunction(location, generation)`/`cancelTimerFlushForTaskGroup(location, generation)` > 来进行清理。请确认所有完成路径 > （包括异常路径）都会执行这些操作，否则在频繁恢复的情况下，这些映射可能会无限增长。 > > 此外，该分支目前存在一些冲突，需要在合并之前解决。 Thanks for the review and coordination. To clarify, #11999 is my PR and provides the smaller, focused fix for #11755, while #11924 takes a broader generation-scoped cleanup approach. I’m happy to avoid duplicating work. If #11924 resolves its remaining cleanup issues and merge conflicts, adds sufficient coverage, and is ultimately preferred by the maintainers, I’m willing to close #11999 as superseded. However, if #11755 needs to be fixed sooner, I suggest merging #11999 first as the focused near-term fix. #11924 could then be rebased and continued separately as follow-up hardening for the broader generation-scoped resource cleanup. I’m fine with either direction—the priority is to get a correct and maintainable fix merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
