Nikk8091 opened a new pull request, #12075:
URL: https://github.com/apache/seatunnel/pull/12075

   ### Purpose of this pull request
   
   Related to #11007.
   
   This PR migrates deterministic HugeGraph sink connection validation into 
`HugeGraphSinkFactory.optionRule()` so invalid configuration is rejected during 
factory validation.
   
   The declarative rules now validate:
   
   - nonblank `host` and `graph_name` values;
   - `port` in the range `[1, 65535]`;
   - `protocol` as `http` or `https` (case-insensitive);
   - `username` and `password` as bundled options; and
   - nonnegative retry count and retry backoff values.
   
   Server, network, schema-dependent, mapping, and record-dependent checks 
remain in their existing runtime paths. No dependencies, configuration options, 
or defaults are changed.
   
   Focused factory tests cover valid defaults and explicit values, blank 
required strings, port boundaries, unsupported protocols, incomplete credential 
pairs, and negative retry settings.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Invalid HugeGraph sink connection settings are now rejected earlier by 
factory configuration validation with the relevant option constraint. Valid 
configurations and all option defaults are unchanged.
   
   ### How was this patch tested?
   
   ```shell
   ./mvnw -pl seatunnel-connectors-v2/connector-hugegraph spotless:apply
   ./mvnw -pl seatunnel-connectors-v2/connector-hugegraph test
   ./mvnw -q -pl seatunnel-connectors-v2/connector-hugegraph -DskipTests verify
   ```
   
   The complete HugeGraph connector unit-test suite passes: 188 tests, 0 
failures, 0 errors, 0 skipped.
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] No documentation update is required because no option, default, or 
valid behavior changes.
   * [x] No incompatible-changes entry is required.
   * [x] Existing connector packaging, mapping, CI labels, and E2E coverage are 
unchanged; this PR only updates factory validation and focused unit tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to