DanielLeens commented on PR #12096: URL: https://github.com/apache/seatunnel/pull/12096#issuecomment-5551389308
Follow-up on my own review above: `Build` was still `IN_PROGRESS` on `4b03079a746` when I wrote that, so here's the promised second pass now that it has completed. The apache-side `Build` check now shows `failure`. I dereferenced the actual fork run (`DanielLeens/seatunnel` run `33926824425`, attempt 1, now complete) instead of trusting the pointer, and the failing jobs are: `transform-v2-it-part-1 (8, ubuntu-latest)`, `doris-connector-it (11, ubuntu-latest)`, and `rocketmq-connector-it` on both JDK 8 and 11 — four jobs total. Every other job, including both `engine-v2-it` matrices and all four `unit-test` matrices, is green. This PR only touches `CheckpointCoordinator.java`, `HdfsStorage.java`, `LocalFileStorage.java`, and their unit tests — nothing under `connector-doris`, `connector-rocketmq`, or `seatunnel-transforms-v2`. So these four failures look like unrelated integration-test flakes rather than anything introduced by this diff; Doris and RocketMQ connector-it jobs in particular have been flaky in other unrelated PRs recently. I'd rerun just those four failed jobs rather than touching any code here. This doesn't change my conclusion above: still no code-side blocker, Issue 1 (test coverage for the `restoresCurrentJob` branch) and Issue 2 (single poisoned checkpoint blocking cleanup) remain non-blocking recommended fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
