DanielLeens commented on issue #12102: URL: https://github.com/apache/seatunnel/issues/12102#issuecomment-5551703916
Thanks @CryoThrust. The narrowed connector-local scope and accepted at-least-once boundary are useful, but STIP-38 needs one deployment contract resolved before connector code starts. Current Mem0 documentation distinguishes the hosted API, where `POST /v3/memories/add/` is asynchronous and returns an event ID, from the self-hosted OSS REST server, which uses `POST /memories` and different authentication and endpoint conventions. A configurable base URL alone is not a documented common protocol. Please revise the STIP to select exactly one Phase 1 profile: either the hosted V3 accepted-at-2xx path with no event polling, or one named self-hosted OSS version with its exact OpenAPI path, authentication, add behavior, and single-memory delete behavior. A multi-profile connector can follow only with explicit capabilities and deterministic coverage for each profile. Do not call accepted additive delivery UPSERT, and reject delete until the selected profile has a documented endpoint and acceptance contract. The current generic HTTP sink is also not a sufficient delivery boundary: it accepts only status 200 and logs failures instead of propagating them. A first implementation should keep a provider adapter and writer connector-local while reusing common HTTP configuration, or propose a separately justified HTTP-base extension with regression tests. Please update the STIP with these boundaries before opening implementation code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
