CryoThrust commented on PR #12101: URL: https://github.com/apache/seatunnel/pull/12101#issuecomment-5556388269
Thanks for the review. I pushed commit `0fec6dd35` with the requested follow-up: - the static-validation failure path now uses the same sanitized message for the thrown `ConfigCheckException` as for the JSON result; - added a regression test with a JDBC URL containing credentials, asserting the exception exposes only `the configured JDBC URL` and not the credential value. Verification: - `mvn -s /Users/yohanes/.m2/settings-public-central.xml -pl seatunnel-core/seatunnel-starter spotless:check -Dspotless.check.skip=false -DskipTests` passed; - the new test was compiled and run separately with Surefire and passed; - the full module test compile in this checkout is still blocked by the existing missing `InMemory`/multi-table test dependencies, unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
