DanielLeens commented on PR #11787:
URL: https://github.com/apache/seatunnel/pull/11787#issuecomment-5558557389
Thanks for the `+1`, @nzw921rx!
Just flagging for the record so it doesn't get lost: the head here is still
`c1d0ae927e` (unchanged since my last review on 2026-09-01), and one
Medium-severity item from that review is still open — the
`iceberg.table.partition-keys` FAQ/options-table text in
`docs/en/connectors/sink/Iceberg.md` and `docs/zh/connectors/sink/Iceberg.md`
still states there's no per-table `${partition_keys}` placeholder for
multi-table jobs, when there actually is one
(`TablePlaceholder`/`TablePlaceholderProcessor`, applied generically to every
sink via `FactoryUtil`/`TableSinkFactoryContext`, with no opt-out in
`IcebergSinkFactory` — details in my previous review). That wording would steer
a multi-table Iceberg sink user toward a worse manual workaround instead of the
feature that already works.
Not blocking on CI or the rest of the content (Build is green, and
everything else I checked holds up), but I'd hold off merging until that one
paragraph is corrected — happy to take another look as soon as it lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
