SEZ9 commented on PR #11077: URL: https://github.com/apache/seatunnel/pull/11077#issuecomment-5564331366
Thanks for the CI triage, @DanielLeens — the retriggers on 4e906741 and a8fabff5 and the cross-links for the connector IT failures are appreciated. On the review side, the earlier points in `MultiTableSink.java` and `SeaTunnelSink.java` still stand. Remaining asks: 1. **Destination-key collisions (F1, HIGH)** — add a guard so two aliases resolving to the same destination key are verified to target the same physical destination (or fail fast), so one table's rows can't be routed through another sink's writer. 2. **Snapshot fan-out + restore union (F2, HIGH)** — emit shared-writer state once (or de-duplicate on restore) so recovery doesn't hand the writer N copies of the same state. A unit test covering snapshot → restore with aliased identifiers would settle this. 3. **Shared writer from an arbitrary alias (F3)** — either validate that all aliased tables agree on the schema/config the shared writer is built from, or document the constraint and reject divergence. 4. **Docs (F4, F6)** — document `getPhysicalDestinationIdentifier()` and the writer-sharing behavior in `docs/`, plus the changed `restoreWriter` contract (merged state from all aliased identifiers passed to a single `SeaTunnelSink#restoreWriter` call) for connector implementers. 5. **proxyContexts (F5)** — register a context for every alias, not just the first per destination, and drop the `containsValue` lookup so startup isn't O(n²). 6. **IOException wrapping (F7)** — avoid wrapping `IOException` from `createWriter`/`restoreWriter` in a `RuntimeException` inside `computeIfAbsent`; propagate it under the declared contract. 7. **Javadoc (F8)** — add the param/return tags on `getDestinationKey`. Happy to re-review once those land and the next Build is green. <!-- streview-comment:856 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
