Nikk8091 opened a new pull request, #12170:
URL: https://github.com/apache/seatunnel/pull/12170

   ### Purpose of this pull request
   
   Handles the Sink / connector-dingtalk slice of #11007.
   
   This change keeps url and secret required and adds declarative notBlank 
conditions so invalid empty or whitespace-only values fail during factory 
configuration validation instead of reaching the writer.
   
   ### Does this PR introduce any user-facing change?
   
   Yes. Empty and whitespace-only DingTalk url and secret values are now 
rejected during configuration validation. Option names and all existing 
nonblank configurations remain unchanged.
   
   ### How was this patch tested?
   
   - Added valid configuration coverage.
   - Added empty-value coverage for both url and secret.
   - Added whitespace-only coverage for both url and secret.
   - DingTalkFactoryTest: 4 tests passed, 0 failures.
   - connector-dingtalk verify: passed.
   - Spotless formatting: passed.
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] Documentation is not required because no option name, default, or 
valid configuration changes.
   * [x] No incompatible change is introduced.
   * [x] Existing connector registration, distribution, CI labels, E2E setup, 
and plugin configuration are unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to