yigitcan-ozturk opened a new pull request, #12175:
URL: https://github.com/apache/seatunnel/pull/12175

   ### Purpose of this pull request
   
   Related to #11007.
   
   This PR implements the accepted connector-typesense source-and-sink 
factory-validation slice.
   
   ### What changed
   
   - Preserve the existing source and sink required/optional structure.
   - Add `Conditions.notEmpty(...)` validation for required `hosts`.
   - Add `Conditions.notBlank(...)` validation for required string connection 
options:
     - source: `api_key`
     - sink: `api_key`, `collection`
   - Leave enum-valued `schema_save_mode` and `data_save_mode` unchanged.
   - Replace the placeholder factory test with focused source and sink 
validation coverage.
   - Preserve option names, defaults, and all existing valid nonblank 
configurations.
   - Do not modify the catalog factory, client construction, network behavior, 
remote Typesense validation, or schema/data-dependent checks.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes.
   
   Invalid empty connection configurations are now rejected during connector 
option validation instead of reaching the Typesense client/runtime path.
   
   Existing valid nonblank configurations and save-mode behavior are unchanged.
   
   ### How was this patch tested?
   
   Focused `ConfigValidator` coverage was added for both source and sink 
configurations, including:
   
   - valid configurations;
   - missing required connection options;
   - empty `hosts`;
   - empty required string values;
   - whitespace-only required string values.
   
   Repository CI will run the connector test suite for this PR.
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature.
   * [ ] If necessary, please update `incompatible-changes.md`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to