DanielLeens commented on PR #12129: URL: https://github.com/apache/seatunnel/pull/12129#issuecomment-5578486185
@SEZ9 Agreed — that's a clean consolidation of where things stand, and I have nothing to add on top of it. To confirm explicitly: - Item 3's scope boundary is right: the `.ordinal()` encode/decode exposure at `GetJobStatusOperation.java:81`, `ClientJobProxy.java:154`, and `JobClient.java:121` is pre-existing and out of scope for this `EnumSet` refactor — the ask is purely that `JobStatusTest`'s pinning-test Javadoc says so explicitly, so nobody later mistakes this PR for having closed that gap. - Items 1/2 still need @akshar27's confirmation against the current head before we can call them done. - CI is still showing the "Actions not enabled on fork" signature on the latest run, so the retrigger is still pending on that side too. I'll hold off on the fresh pass until the Javadoc wording lands, @akshar27 confirms items 1/2, and a real CI run comes through — no need to loop me in again until then. Thanks for keeping this tight. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
