DanielLeens commented on PR #12142: URL: https://github.com/apache/seatunnel/pull/12142#issuecomment-5593923340
Heads-up: GitHub is currently reporting a real merge conflict against `dev` for this branch (`mergeStateStatus: DIRTY`), separate from the CI/code-review discussion above. The `Build` check shown as green right now is running against the current (pre-sync) head, not a `dev`-merged version, so it doesn't reflect the conflicting state. Could you please sync the latest `dev` into your branch and resolve the conflicts? Once that's pushed and CI is green on the updated head, I'll take another pass — my previous review's Issue 1 (the `Awaitility`/`ignoreExceptions()` + `try/finally` gap, and the overlap with #12136) is still open too, so it'd be worth addressing both in the same push. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
