DanielLeens commented on PR #12153: URL: https://github.com/apache/seatunnel/pull/12153#issuecomment-5627581051
Hi @zhangsean — just circling back so the two remaining action items don't get lost in the repeated notification above (that message is an automated reminder, not something new from a person, so no need to worry it means something went wrong with your code). To get this PR to a mergeable state, two things are needed on your side, and both are quick: 1. **Enable GitHub Actions on your fork** (`zhangsean/seatunnel`) — right now Actions has never run there, which is why the `Build` check shows `ACTION_REQUIRED` instead of pass/fail. GitHub's own guide: https://docs.github.com/en/actions/how-tos/manage-workflow-runs/disable-and-enable-a-workflow. David's comment above links the specific check-run reference for this PR. 2. **Run `./mvnw spotless:apply -pl seatunnel-connectors-v2/connector-jdbc -am -nsu` locally and push the result** — your diff currently carries some unrelated line-ending/formatting changes that will fail the format-check step on their own, independent of the actual fix. To be clear about where things stand: the core logic fix (FULLTEXT/SPATIAL index handling in `MySqlCatalog` / `MysqlCreateTableSqlBuilder`) already looked correct and well-tested when I reviewed it — this is purely about getting CI able to actually run and pass, not about anything wrong with the fix itself. Once both of the above are done and a new commit lands, I'll take another look right away. Thanks again for the contribution, and don't hesitate to ask here if you hit any trouble enabling Actions or running spotless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
