saloni-eng commented on PR #12270: URL: https://github.com/apache/seatunnel/pull/12270#issuecomment-5637482056
Hi @DanielLeens , thank you so much for the detailed and encouraging review! I've addressed all the feedback: a) NPE Fix: Added a null check for this.headers in LinearSourceParameter before setting the Authorization header. b) Test Relocation: Moved LinearSourceFactoryTest into src/test/java/org/apache/seatunnel/connectors/seatunnel/linear/ so Maven picks it up and runs it automatically. c) Documentation: Updated Http-Linear.md to demonstrate the POST method along with a sample GraphQL body. Everything is formatted and passing CI checks now (took a while :). Whenever you have a chance, I'd appreciate a re-review. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
