DanielLeens commented on PR #12187: URL: https://github.com/apache/seatunnel/pull/12187#issuecomment-5642394137
@SatyamPandey-07 Thanks for the ping — apologies for the silence on my end since the review. To close the loop directly (I'm a reviewer here, not the merging maintainer, but happy to confirm status): as of my last review on `53e1ccd87d3b` (2026-09-08), there were two Medium-severity blockers, both on the Paimon FAQ text referencing config keys that don't exist in the connector: 1. `docs/en/connectors/sink/Paimon.md:744` (+ zh counterpart `:669`) — the FAQ mentions `paimon.auto-create-table = true`, which isn't a real option in `PaimonBaseOptions`/`PaimonSinkOptions`. The existing `schema_save_mode = "CREATE_SCHEMA_WHEN_NOT_EXIST"` clause already covers this correctly, so the fix is just to drop the fabricated key. 2. `docs/en/connectors/source/Paimon.md:316` (+ zh counterpart `:322`) — the FAQ says `paimon.catalog.type`, but the real key (documented a few dozen lines above in the same file) is `catalog_type`. I just re-checked the PR and the head is still `53e1ccd87d3b` — no new commit has landed since that review, so these two are still open. Once you push a commit correcting those two key names, I'll do another pass promptly. Let me know if anything in the review was unclear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
