DanielLeens commented on PR #12209: URL: https://github.com/apache/seatunnel/pull/12209#issuecomment-5645088521
Thanks for the work here. Two things to flag together: (1) GitHub is currently reporting merge conflicts between this branch and the latest `dev` -- could you please sync with `dev` and resolve those first? (2) Separately, my last review's Issue 1 is still open and was called out as a blocker independent of CI: lineage emission currently runs on the shared, effectively-unbounded `CoordinatorService` executor (`JobMaster.submitLineageEmission`/`drainLineageEmissions`), which risks cluster-wide thread growth under a slow lineage receiver. Once the conflicts are resolved and Issue 1 is addressed (a small dedicated bounded pool for lineage emission, per my earlier suggestion), and checks are rerun, I'm happy to take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
