1328837476-hug opened a new pull request, #12278:
URL: https://github.com/apache/seatunnel/pull/12278

   ### Purpose of this pull request
   
   This PR adds declarative factory validation for the GoogleFirestore sink as 
part of #11007:
   
   - keep `project_id` and `collection` required and reject blank values
   - keep `credentials` optional while rejecting an explicitly blank value
   - preserve credential parsing, SDK, remote, and runtime behavior
   - add focused factory-level regression coverage
   - update the matching EN and ZH connector documentation
   
   Relates to #11007.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Invalid GoogleFirestore sink configurations are now rejected during 
factory option validation:
   
   - blank `project_id` or `collection` values are rejected
   - omitted `credentials` remains valid
   - explicitly blank `credentials` values are rejected
   
   ### How was this patch tested?
   
   Added and ran `FirestoreFactoryTest`, covering valid configurations, missing 
and blank required options, omitted and blank optional credentials, and unknown 
options.
   
   ```bash
   mvn -q -pl seatunnel-connectors-v2/connector-google-firestore -DskipITs 
-Dtest=FirestoreFactoryTest test
   ```
   
   The connector test suite and connector-scoped Maven `verify` also passed.
   
   ### Check list
   
   * [x] No new Jar binary package is added.
   * [x] The EN and ZH connector documentation is updated.
   * [x] No incompatible runtime behavior is introduced.
   * [x] Existing-connector-only change; plugin mapping, distribution POM, CI 
labels, E2E registration, and plugin configuration do not require updates.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to