Rangsh commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-5665171420
@DanielLeens Thanks for catching the classloader-release race — that was a real gap in the rollback path. **Issue 1 (atomic claim):** addressed in `4de899d4e`. - Added `TaskGroupContext.claimJarsForClassLoaderRelease()` (`AtomicBoolean` compare-and-set) so only the first of `releaseClassLoadersFromPublishedContext` / `recycleClassLoader` actually calls `ClassLoaderService.releaseClassLoader`. - Both paths now go through a shared `releaseClassLoadersOnce(...)`. - `BlockingWorker` / `CooperativeTaskWorker` use null-safe `getClassLoader(taskId)` so a concurrent claim cannot NPE mid-start. - Added unit coverage for single-claim semantics and “rollback claims first, then `taskDone`/`recycleClassLoader` must not double-decrement a sibling task group’s shared job-scoped ref count”. **Issue 2 (`SplitClusterFaultToleranceIT`):** acknowledged. This commit does not touch that cancel/failover path; we’ll root-cause it against a clean `dev` baseline / re-run `engine-v2-it` on the updated head (and treat the Maven wrapper 403 as infra needing a clean rerun). Happy to follow up once CI on `4de899d4e` is available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
