DanielLeens commented on PR #12115: URL: https://github.com/apache/seatunnel/pull/12115#issuecomment-5661980169
Thanks for taking a look and for the approval, @nzw921rx. There's no new commit since my last review (head is still `2cd0571e`, from 2026-09-05/06), so there's nothing new to re-verify on the code side — this is just acknowledging the extra pair of eyes. I re-checked CI live on the current head: `Build` is complete and green across the board (all jobs success/skipped), including both `rocketmq-connector-it` legs with the stricter name-server-route wait this PR adds, so the fix is exercising the path it's meant to harden. `mergeStateStatus` is currently `BLOCKED`, but that looks like it's only waiting on a maintainer with write access to perform the formal merge — both existing reviews (mine and yours) are `APPROVED`, and I don't see any other open item. My "ready to merge" conclusion from the last round stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
