SEZ9 commented on issue #12317: URL: https://github.com/apache/seatunnel/issues/12317#issuecomment-5691942095
Thanks for the detailed report and the `SQLNumericComparisonTest` reproduction. Silently matching BIGINT `9007199254740993` against `a = 9007199254740992` is a correctness bug, and since `ZetaSQLFilter` funnels equality, ordering, `IN`/`NOT IN` and the CASE comparison path through `doubleValue()`, fixing that shared path with `Long.compare` / `BigDecimal.compareTo` is the right approach. Review can continue on #12318. One open point: the issue notes that released-version coverage has not been established. Could you check whether any released version shares the same double-based comparison logic? That would help us define the affected-version range and decide on any backport. <!-- streview-comment:1094 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
