Nikk8091 opened a new pull request, #12351: URL: https://github.com/apache/seatunnel/pull/12351
### Purpose of this pull request This PR handles the `connector-selectdb-cloud` sink slice of #11007. It adds declarative `notBlank` validation for the five existing required string options: - `jdbc-url` - `load-url` - `cluster-name` - `username` - `table.identifier` `password` remains optional. The change does not modify writer, retry, two-phase commit, client, or network behavior. ### Does this PR introduce any user-facing change? Yes. Missing, empty, and whitespace-only values for the five required options are rejected during factory configuration validation. Nonblank values, including values with surrounding spaces, remain accepted. The English and Chinese connector documentation now states these constraints and correctly identifies `password` as optional. ### How was this patch tested? Added focused `SelectDBSinkFactoryTest` coverage for: - a valid configuration; - all five required values with surrounding spaces; - each required option when missing; - each required option when empty; - each required option when whitespace-only; - an omitted or empty optional password. Validation performed: - repository-wide `mvnw spotless:apply`: passed; - `mvnw -pl seatunnel-connectors-v2/connector-selectdb-cloud -DskipITs verify`: passed (9 tests, 0 failures, 0 errors, 0 skipped); - `git diff --check`: passed; - repository-wide `mvnw -q -DskipTests verify`: attempted and stopped after more than one hour without a reported failure; the connector-scoped `verify` above completed successfully. ### Checklist notes - No new dependency was added. - No connector registration, distribution, label, E2E, writer, retry, two-phase commit, client, or network change is required. - This PR is limited to the approved SelectDB Cloud connector scope in #11007. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
