DanielLeens commented on PR #12194: URL: https://github.com/apache/seatunnel/pull/12194#issuecomment-5713038338
Thanks for tracking this down, and for being explicit that no boolean-validation code changed here — I independently confirmed that against the fork run for this exact head (`efe4aee633d`, https://github.com/goutamadwant/seatunnel/actions/runs/34918537638), rather than taking the summary at face value. I pulled the actual failing jobs/logs directly: - `TaskExecutionServiceTest.testStaleTaskDoneCleansOnlyOwnedGenerationResources` does fail in `unit-test (11, ubuntu-latest)` at `seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/TaskExecutionServiceTest.java:639` — matches your execution-ID-collision diagnosis exactly, and it's entirely in `seatunnel-engine-server`, nowhere near `LLMTransform`/`nlpmodel/llm/**`. Good catch; the fixture-isolation fix belongs in its own PR as you said, not folded into this one. - `transform-v2-it-part-1 (11)` fails again on `TestFilterRowKindIT.testFilterRowKindMultiTable` — the same pre-existing, unrelated `dev`-side flake I flagged in my 09-14 review, still not fixed on `dev`. This PR's own `TestLLMIT.testLLMWithOpenAIStrictBoolean` and `...RejectsInvalidOutput` both pass in that same job log. - `engine-v2-it (8)` and `all-connectors-it-2/6` are also red, but in unrelated modules — nothing touching `LLMTransform` shows up in any of them. So: this PR's own code and tests remain green everywhere they actually run; every current red job traces back to shared, unrelated `dev`-side test infrastructure, not this PR's diff. Once the fixture-isolation fix lands (or this run is otherwise green), there's nothing left blocking merge on my end. As I have comment-only rights here, a maintainer with write-level review permission will need to give the final approve/merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
