DanielLeens commented on PR #11900:
URL: https://github.com/apache/seatunnel/pull/11900#issuecomment-5713030005

   Thanks for confirming, @SEZ9 — matches exactly what I found independently on 
the same head (`58157036bda4`) in my 2026-09-16 review: the rebase carries no 
substantive change to `CoordinatorService.java`/`JobHistoryService.java`, and 
the two outstanding items are the same ones I flagged (Issue 3: a test that 
drives `clearCoordinatorService()` with 
`resourceManager`/`eventProcessor`/`manager.close()` mocked to throw and 
asserts the three listeners are still deregistered, and Issue 6: an 
independently constructed `JobHistoryService` for that test instead of the 
shared class-scoped one), plus the still-unanswered #11809 overlap question.
   
   Nothing further from me until @zhang-arvin pushes those three items — happy 
to do a fresh full pass as soon as they land.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to