DanielLeens commented on PR #12312: URL: https://github.com/apache/seatunnel/pull/12312#issuecomment-5728611882
Hi @xinnyuli — I think this comment landed on the wrong thread. The `java.io.IOException` / static `assertThrows` import fix in `bde946ff6`, and the note about rebasing after this PR merges, are about #12376 (`HttpSinkBatchWriterTest` regression-coverage PR), not this PR's own diff — #12312 doesn't touch those imports. No action needed here on my side. For the record, since it's relevant: I already re-reviewed #12376's `bde946ff6` head, confirmed the missing-import fix compiles cleanly against fresh fork CI, traced both of its new tests against this PR's actual diff to confirm they'll pass once this PR merges, and approved it. The sequencing you described is exactly right — keep #12376 in Draft, this PR (#12312) merges first, then rebase #12376 and flip it out of Draft. Expect a small, trivial conflict in `HttpSinkBatchWriterTest.java`'s import block / insertion point when you do, since both PRs add new tests near the same spot in that file — nothing to be concerned about. This PR itself (#12312) has no outstanding blockers from my side and CI is green — my "Ready to merge" conclusion from earlier still stands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
