DanielLeens commented on PR #12306: URL: https://github.com/apache/seatunnel/pull/12306#issuecomment-5728656469
Thanks @dybyte for taking a look and +1'ing this! Agreed on the conclusion — I traced the root cause independently in my review above (the same-millisecond `RestoreTableSchemaEvent` collision hitting `SchemaOperator#applyNextPendingSchemaChange`'s staleness dedup) and confirmed the fix is scoped correctly and doesn't touch the real-DDL staleness guard. On the "if CI passes" condition specifically: I re-checked the actual CI run for the current head (`0695aa3f5995`, the "Merge branch 'dev' into ..." commit). The apache-side "Build" check is just a pointer — the real run lives on the fork: `nzw921rx/seatunnel` run `34967398751`. It currently shows **3 failing jobs**: `all-connectors-it-2 (8, ubuntu-latest)` and `all-connectors-it-2 (11, ubuntu-latest)` (both failing at the "run connector-v2 integration test (part-2)" step), plus `engine-v2-it (8, ubuntu-latest)`. 80 other jobs passed and 11 were skipped as expected given this PR's footprint. This PR only touches `seatunnel-translation-flink-common` (`SchemaOperator.java` plus its unit test) — none of the connector-v2 modules exercised by the `all-connectors-it-2` batch, nor the generic Zeta `engine-v2-it` suite, are part of this diff. So these read as pre-existing/environmental IT flakiness rather than a regression introduced here, consistent with the pattern of unrelated-IT-job failures I flagged against the prior run in my Sept 15 review — but that run predates this merge-into-dev commit, so I hadn't verified CI on this exact head until now. Net: as of this moment, CI is **not** green for the current head, so the "+1 if CI passes" condition isn't fully satisfied yet. I'd suggest re-running those two job types to confirm they're flaky rather than a real regression before merging. Nothing on the code side blocks this from my end — my "Ready to merge" conclusion from the Sept 15 review stands once CI is confirmed clean (or confirmed pre-existing on `dev`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
