SEPURI-SAI-KRISHNA commented on PR #12393: URL: https://github.com/apache/seatunnel/pull/12393#issuecomment-5742715460
CI is green on `5de3911b8`. Both `rocketmq-connector-it` legs passed, JDK 11 at 11:10 and JDK 8 at 11:17, with no failed job anywhere in the run. The JDK 11 leg reports 87 tests, 0 failures, 0 errors, against 87 tests with 14 errors on the previous head where the repair attempt was still in place. Those 14 were both tag tests on every engine leg, which is the deterministic failure your Issue 1 predicted. The `Failed to delete topic ...: connect to null failed` warning that appears 14 times per job log on `dev` is also now absent, which is the other half of the evidence that the helper was a no-op and is gone. So this matches `dev` rather than diverging from it, as expected for removing dead code, and there was no RocketMQ leg failure to compare against #12322. Thank you for withdrawing Issue 3 so directly, and for going to the upstream 4.9.4 broker source on the offset question rather than taking my word for it. The `scanUnsubscribedTopic` predicate point was one I had not checked. I will open the topic and consumer group isolation change as a separate PR shortly, following the `uniqueTestSuffix()` plus job-variable pattern this file already uses at `RocketMqIT.java:388-389` and `:429-431`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
