SEPURI-SAI-KRISHNA commented on PR #12406: URL: https://github.com/apache/seatunnel/pull/12406#issuecomment-5748121334
Two things I checked after opening this, worth stating rather than leaving for review. **A gap in the test I committed.** It serializes the source before `setJobContext` is called, while the engine sets the job context first. So the committed test does not exercise the production ordering. I verified that path separately with a throwaway test: a full config with `username`, `password` and `format`, `setJobContext(new JobContext().setJobMode(JobMode.STREAMING))`, then a round trip. It passes. I did not add that as a second test, because `JobContext` is `public final class JobContext implements Serializable` and `CatalogTable` is serializable too, so the ordering only exercises fields this PR does not change. The committed test targets the one field that was broken and fails without the fix. Happy to add the job-context variant if you would rather have the production ordering pinned as well. For completeness, those are all three fields on `MqttSource`: `MqttSourceConfig` (fixed here), `CatalogTable` and `JobContext`. `AbstractSingleSplitSource` declares none of its own, so nothing else on the source is unserializable. **Whether other connectors have the same defect.** They do not. I scanned every `*Source.java` under `seatunnel-connectors-v2` for fields typed `*Config`, `*Configuration` or `*Options`, resolved each of those types to its declaration, and checked for `Serializable`: 44 source-and-config pairs, and MQTT was the only one missing it. I sanity-checked the scan by confirming it flags `MqttSourceConfig` with the pre-fix declaration and stops flagging it with the fix, so the empty result is a real one rather than a query that matches nothing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
