SEZ9 commented on PR #11734:
URL: https://github.com/apache/seatunnel/pull/11734#issuecomment-5755225778
Thanks @goutamadwant for following up, and for taking @davidzollo's process
point on board.
On your question: since #11735 is the canonical STIP discussion, my
preference is to close this design-only PR once the security points below have
been carried over into that issue (or the dev@ list), rather than keeping two
places for the same design.
The items I'd like to see explicitly addressed in the #11735 record:
1. `GET /job-info/{jobId}/failures` — the contract still needs a stated
authentication/authorization expectation and a redaction requirement for
exception messages and stack traces before they leave the server.
2. Persistence of failure records in the HA-backed Hazelcast IMap — the
capture-time redaction/truncation should be spelled out as a requirement for
what is written to the IMap, not only for what the REST layer returns, since
the retention window (following `history-job-expire-minutes`, as you note)
means this data lives across the cluster for a while.
3. Worker `host:port` in the response — please either drop it from the
default response or make it explicitly opt-in / operator-only, and note the
rationale in the design.
4. `JobInfoServlet` routing and the `limit` parameter — please add concrete
validation rules (allowed range, default, behaviour on invalid input) to the
contract.
If you add those to #11735 and drop a link here, I'm happy for this PR to be
closed. Agreed that the substance needs to be settled on the issue side.
<!-- streview-comment:1216 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
