SEPURI-SAI-KRISHNA commented on PR #12410: URL: https://github.com/apache/seatunnel/pull/12410#issuecomment-5756151822
Thanks @SEZ9, I read through all three and they are all correct. This is already in the merge queue, so I will not push into it; the fixes are written and verified locally and I will open them as a follow-up as soon as this lands, and link it here. Two notes so the record is straight before then. Your summary point that the source round trip never inspects `sourceConfig` is worth more than a summary line: with that field marked `transient` in `MqttSource`, every test in the module still passes today. And the `qos` and `clean_session` values I chose are wrong for the purpose, which is my error rather than anything you missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
