Vivek1106-04 commented on PR #12418:
URL: https://github.com/apache/seatunnel/pull/12418#issuecomment-5758374978
All three items are pushed.
- Heap: `e8a8450b0`, 4g, matching `CheckpointingTimeBenchmark`.
- README: `556de1f92`, reverted. I had missed that the benchmark
documentation
moved to `docs/en/engines/zeta/benchmark.md`; that file is unchanged too.
- `benchmarks.yml`: `556de1f92`, `CheckpointSchedulingBenchmark` is now in
the
`benchmarks` choice list next to `CheckpointingTimeBenchmark`.
`tools/benchmarks/test_run_benchmarks.py` still passes, 7/7.
One judgement call I did not make on my own: I did **not** add it to
`tools/benchmarks/suites/benchmarks_core.txt`. The benchmark has 8 parameter
configurations (`pipelineNum` 1/10/100/500 x `triggerBodyMicros` 0/500) at
roughly 4 minutes each, so nightly inclusion costs about 32 minutes per Java
version against the 240-minute budget, and the suite file selects by class or
method, so the parameter matrix cannot be narrowed there.
If you want it tracked nightly the options are to take that cost, or to cut
the
defaults in the benchmark itself to a smaller matrix and keep the full sweep
for
manual dispatch. That is your call on the nightly budget - say which and I
will
push it.
I am running the full sweep on `dev` now and will post the numbers here, then
the identical sweep against #12165 so both scheduling models are measured on
the
same settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
